Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Docker run_command validation is incorrect, should be list of strings #133

Closed
Tegereo opened this issue Oct 10, 2018 · 4 comments
Closed

Comments

@Tegereo
Copy link

Tegereo commented Oct 10, 2018

'run_command': (str, False),

Docker run_command should be a list of strings, not a string. See https://www.packer.io/docs/builders/docker.html#run_command

I'll throw a pull request together if I get the time, but wanted to at least document.

@mayn
Copy link
Owner

mayn commented Oct 10, 2018

@Tegereo, Thanks for reporting

@mayn mayn added this to the 1.0.2 milestone Oct 10, 2018
@gnewson
Copy link
Contributor

gnewson commented Oct 11, 2018

Hi,
Can I take this issue to work on?

Thanks,
Geoff,

@PacketPerception
Copy link

@gnewson first one to a pull request wins! (It wont be me, i have no free time anymore)

@mayn mayn closed this as completed in 520dc57 Oct 13, 2018
mayn added a commit that referenced this issue Oct 13, 2018
fixes #133 builders/Docker run_command should accept a list of strings
@mayn
Copy link
Owner

mayn commented Oct 13, 2018

@PacketPerception v1.0.2 was released w/ this change. Thanks!

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

4 participants