Fix pint/(X instances) cache error #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On my AMD Ryzen 5 5600X 6-Core cpu, `py-cpuinfo` was returning `192 KiB (6 instances)` which got `pint` confused since it is expecting only `192 KiB`. My solution is to keep only the first two "words" (i.e. number and unit) and throw away the rest.
Codecov Report
@@ Coverage Diff @@
## master #8 +/- ##
==========================================
- Coverage 96.04% 87.40% -8.65%
==========================================
Files 27 27
Lines 936 937 +1
Branches 110 110
==========================================
- Hits 899 819 -80
- Misses 27 103 +76
- Partials 10 15 +5
Continue to review full report at Codecov.
|
mbdevpl
added a commit
that referenced
this pull request
Aug 27, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my AMD Ryzen 5 5600X 6-Core cpu,
py-cpuinfowas returning192 KiB (6 instances)which gotpintconfused since it is expecting only192 KiB. My solution is to keep only the first two "words" (i.e. number and unit) and throw away the rest.