Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade pdfjs to version 4 -- On hold till better browser support exists #18

Merged
merged 17 commits into from
Mar 25, 2024
+2,479 −4,825
Merged

Upgrade pdfjs to version 4 -- On hold till better browser support exists #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ac51411
Initial work.
thebensnow Mar 15, 2024
28b90c6
set up express server, fix double rendering
SuttonKyle Mar 15, 2024
3d6f450
switch to e2e tests using playwright, remove commonjs
SuttonKyle Mar 20, 2024
a0ce7a7
update prepublish script
SuttonKyle Mar 20, 2024
09632c6
modify ci workflow
SuttonKyle Mar 20, 2024
d08bc88
use dotenv
SuttonKyle Mar 20, 2024
2a957da
maybe fix base url?
SuttonKyle Mar 20, 2024
e3a12e4
more testing
SuttonKyle Mar 20, 2024
6fce97c
remove nonexistent tsconfigs
SuttonKyle Mar 20, 2024
a6345a3
fix document resolution?
SuttonKyle Mar 20, 2024
32df783
add caching
SuttonKyle Mar 20, 2024
ba52eaa
add more workflows
SuttonKyle Mar 20, 2024
68dbb58
fix ci
SuttonKyle Mar 20, 2024
ed0435e
move artifacts call to end of workflow
SuttonKyle Mar 20, 2024
309d80e
fix merge conflicts
SuttonKyle Mar 20, 2024
a8c097a
remove commented code
SuttonKyle Mar 21, 2024
adec4e6
add eslint to js files
SuttonKyle Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
384 changes: 194 additions & 190 deletions .eslintrc.js
View file
Open in desktop

Large diffs are not rendered by default.

17 changes: 14 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,15 +9,26 @@ jobs:

steps:
- name: Check out Git repository
uses: actions/checkout@v2
uses: actions/checkout@v4

- name: Set up Node.js
uses: actions/setup-node@v2
uses: actions/setup-node@v4
with:
node-version: 18
cache: 'npm'

- name: Install Node.js dependencies
run: npm ci

- name: Install Playwright Browsers
run: npx playwright install --with-deps

- name : Run test
run: npm run prepublishOnly
run: npm run prepublishOnly

- uses: actions/upload-artifact@v4
if: always()
with:
name: playwright-report
path: playwright-report/
retention-days: 30
8 changes: 7 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,10 @@ build/
dist/

.git/
.vscode/
.vscode/

.DS_Store
/test-results/
/playwright-report/
/blob-report/
/playwright/.cache/
Comment on lines +9 to +12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be relative

4 changes: 2 additions & 2 deletions example/example.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
import { init } from '../dist/es2015';
import { init } from '../dist/esnext';

init('../node_modules/pdfjs-dist/build/pdf.worker.min.js');
init('http://localhost:8080/pdf.worker.min.mjs');
2 changes: 1 addition & 1 deletion example/viewer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
</head>
<body>
<div class="viewer-container" id="doc-1" data-document-url="https://raw.githubusercontent.com/mozilla/pdf.js/ba2edeae/web/compressed.tracemonkey-pldi-09.pdf"></div>
<div class="viewer-container" id="doc-2" data-document-url="https://www.w3.org/TR/PNG/iso_8859-1.txt"></div>
<div class="viewer-container" id="doc-2" data-document-url="https://example-files.online-convert.com/document/txt/example.txt"></div>
<div class="viewer-container" id="doc-3" data-document-url="http://ieee802.org:80/secmail/docIZSEwEqHFr.doc"></div>
<div class="viewer-container" id="doc-4"></div>
</body>
Expand Down
5 changes: 0 additions & 5 deletions jest.config.js
View file
Open in desktop

This file was deleted.

Loading