correctly manage transmission power with addition of a MAX_RFO_PWR se…

[disk91]

…tting
The objective is to correctly manage the TX power setting on sx1276 with an optimal current consumption.
The MAX_RFO_PWR allows to set the limit between use of PA_BOOST vs RFO. When the device does not have RFO connected like for RFM95 this setting must be set to 0.

[terrillmoore]

Hi, thanks for your input. This looks like it will address #46, which has been on the list for some time.

Unfortunately, your patch doesn't compile. Perhaps there's a missing commit to a header file? For example:

lib/arduino-lmic/src/lmic/radio.c: In function 'configPower':
lib/arduino-lmic/src/lmic/radio.c:459:22: error: 'MAX_RFO_PWR' undeclared (first use in this function)
} else if ( pw > MAX_RFO_PWR ){
^
lib/arduino-lmic/src/lmic/radio.c:459:22: note: each undeclared identifier is reported only once for each function it appears in

Best regards,
--Terry

[disk91]

project_config/lmic_project_config.h has also been patched for declaring MAX_RFO_PWR ; it's part of the pull request. Did you add this line to your file ?

[terrillmoore]

Please see travis build log. First step is to pass travis builds, without that we can't make progress. The ESP32 logs are easier to follow than the others, because there's less build-system noise. Click on the Details button for the failing build, and dig down to the ESP32 build.

In any case, your commit did not include the project_config file, and so that didn't get updated in Travis, which is why the build is broken.

We may need to reorganize; MAX__RFO_POWER, if it's a user configurable item, needs to go into the configuration table, rather than being a compile parameter, because Arduino compile-time config is such a headache. It looks like it's only one byte, so this is easy. But first step is to get a clean build. Thanks!

[terrillmoore]

I have used some of the ideas from this, but because of the need to get policy from the user's configuration, my implementation is substantially different. See #46 and related pull requests.

[terrillmoore]

Superseded by #319