Fixing infinite loop issue in reionization code #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 6, 2018 13:36
proton back and forth from the same two locations. This fixes this bug by keeping track on hydrogen moves already performed and disallowing hydrogen moves between the same two atoms to occur again. If that is detected the loop is terminated.
|
Thanks Brian |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of the reionization code entering an infinite loop as first reported here:
#14
The fix prevents a proton from migrating between the same two atoms twice. If such a case is detected it assumes an infinite loop will be encountered and terminates the loop with a warning.