Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Define Service API (for database) #296

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Conversation

mdabrowski1990
Copy link
Owner

Description

  • created AbstractService class

How Has This Been Tested?

  • review

Process

I know the process and did my best to follow it

@mdabrowski1990 mdabrowski1990 added the implementation Changes to code label Nov 8, 2024
@mdabrowski1990 mdabrowski1990 self-assigned this Nov 8, 2024
@mdabrowski1990 mdabrowski1990 linked an issue Nov 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4acb193) to head (351526d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #296   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        46    +2     
  Lines         2797      2818   +21     
  Branches       345       345           
=========================================
+ Hits          2797      2818   +21     
Flag Coverage Δ
integration-tests 81.33% <100.00%> (+0.14%) ⬆️
integration-tests-branch 76.29% <100.00%> (+0.17%) ⬆️
unit-tests 100.00% <100.00%> (ø)
unit-tests-branch 100.00% <100.00%> (ø)
Files with missing lines Coverage Δ
uds/database/__init__.py 100.00% <100.00%> (ø)
uds/database/abstract_data_record.py 100.00% <100.00%> (ø)
uds/database/services/__init__.py 100.00% <100.00%> (ø)
uds/database/services/abstract_service.py 100.00% <100.00%> (ø)

n135c10r
n135c10r previously approved these changes Nov 10, 2024
@n135c10r
Copy link
Collaborator

Approved. However, I suggest creating a separate folder for services to maintain organization, as the database package is expected to grow with additional modules in the future.

@mdabrowski1990
Copy link
Owner Author

Approved. However, I suggest creating a separate folder for services to maintain organization, as the database package is expected to grow with additional modules in the future.

True, we will need it later. Done.

Copy link
Owner Author

@mdabrowski1990 mdabrowski1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdabrowski1990 mdabrowski1990 merged commit c65988b into main Nov 11, 2024
61 checks passed
@mdabrowski1990 mdabrowski1990 deleted the service-database-api branch November 11, 2024 21:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
implementation Changes to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UDS Service database API
2 participants