-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Define Service API (for database) #296
Conversation
- create AbstractService class
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 46 +2
Lines 2797 2818 +21
Branches 345 345
=========================================
+ Hits 2797 2818 +21
|
Approved. However, I suggest creating a separate folder for services to maintain organization, as the database package is expected to grow with additional modules in the future. |
True, we will need it later. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
How Has This Been Tested?
Process
I know the process and did my best to follow it