Now message-box/bt class will restart thread if it was aborted because of a non-local exit from processing loop. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e of a non-local exit from processing loop. I've measured performance before these changes and after them and didn't notice significant changes. Results of the benchmark along with the baseline results are available in this gist: https://gist.github.com/svetlyak40wt/a1097ab7d501087ca366d5addb410ebe
svetlyak40wt
force-pushed
the
resurrect-threads2
branch
from
c73d284 to
46aae6b
Compare
mdbergmann
requested changes
Jan 30, 2025
sento.asd
Outdated
| ))) | ||
| (:file "test-utils") | ||
| (:file "message-box-test" | ||
| :depends-on ("test-utils"))))) |
There was a problem hiding this comment.
Since test-utils is defined before if the depends-on necessary?
There was a problem hiding this comment.
No, unless you have :serial t option in the defsystem form.
There was a problem hiding this comment.
OK, just add a serial t then. In main system we have it as well. I think it's straight forward when the loading mirrors the dependency structure roughly.
mdbergmann
approved these changes
Jan 30, 2025
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've measured performance before these changes and after them and didn't notice significant changes. Results of the benchmark along with the baseline results are available in this gist:
https://gist.github.com/svetlyak40wt/a1097ab7d501087ca366d5addb410ebe
Note, this PR is the replacement for #101
It uses another approach for checking if thread is died – catches non-local exit using
unwind-protect.Also, in this thread I've removed a special brach for processing the
time-outwhile waiting for response. Now both cases (withtime-outand without) are handled using the same code, relying ontimeoutargument of condition wait function.Peformance testing didn't show any difference with the code from the master branch.