Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add missing statements for webview_ios #24657

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RupertBenWiser
Copy link

I tried to generate web-features locally using WebViews as part of the browser set.

I found that there were a few keys that webview_ios wasn't set for.

As far as I can see, in each of the places it was missing it was set as mirror for other keys for those elements.

I tried to generate web-features locally using WebViews
as part of the browser set.

I found that there were a few keys that webview_ios
wasn't set for.

As far as I can see, in each of the places it was missing
it was set as mirror for other keys for those elements.
@github-actions github-actions bot added the data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Oct 7, 2024
@RupertBenWiser
Copy link
Author

Leaving this open for the moment, will return to it. I will just flag that there are a few places like this that will mean we can't run baseline for WebViews yet.

@RupertBenWiser RupertBenWiser marked this pull request as draft October 7, 2024 15:42
@caugner

This comment was marked as outdated.

@queengooborg queengooborg changed the title Add missing web-features fields for webview_ios Add missing statements for webview_ios Oct 12, 2024
@github-actions github-actions bot added the size:m [PR only] 25-100 LoC changed label Nov 22, 2024
@caugner
Copy link
Contributor

caugner commented Jan 8, 2025

@RupertBenWiser Do you have any concerns with merging this? Here are the effective changes:

image
(Text version)
version = "1+"
  html.elements.link.rel               .webview_ios
  html.elements.meta.http-equiv.refresh.webview_ios

version = "2+"
  html.elements.del.cite     .webview_ios
  html.elements.del.datetime .webview_ios
  html.elements.fieldset.form.webview_ios
  html.elements.iframe.height.webview_ios
  html.elements.iframe.name  .webview_ios
  html.elements.iframe.width .webview_ios
  html.elements.ins.cite     .webview_ios
  html.elements.ins.datetime .webview_ios

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML size:m [PR only] 25-100 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants