Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move CSS env() function into css.types.* #25645

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Move CSS env() function into css.types.* #25645

wants to merge 1 commit into from

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Jan 13, 2025

Summary

Moves env() from css.properties.custom-property to css.types.

Test results and supporting details

Related issues

Fixes #14668.

@caugner caugner requested a review from Elchi3 January 13, 2025 22:14
@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:l [PR only] 101-1000 LoC changed labels Jan 13, 2025
queengooborg
queengooborg requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that we should also move var() if we're moving env(), WDYT?

@queengooborg queengooborg added the needs collector update This PR needs a corresponding update to openwebdocs/mdn-bcd-collector. label Feb 13, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@queengooborg queengooborg queengooborg requested changes

@Elchi3 Elchi3 Awaiting requested review from Elchi3

@ddbeck ddbeck Awaiting requested review from ddbeck

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS needs collector update This PR needs a corresponding update to openwebdocs/mdn-bcd-collector. size:l [PR only] 101-1000 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

css.properties.custom-property - does env() belong here?
2 participants
@caugner @queengooborg