Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Document durationThreshold in PerfObserver.observe() #21552

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Oct 14, 2022

Description

This PR updates https://developer.mozilla.org/en-US/docs/Web/API/PerformanceObserver/observe to add the durationThreshold option from the Event Timing API.

Spec: https://w3c.github.io/event-timing/#sec-modifications-perf-timeline

Motivation

openwebdocs/project#62

Additional details

I also ordered the options list alphabetically and removed explicit mention of "PerformanceObserverInit dictionary" because I believe we don't document dictionaries anymore and all we want readers to know is that it is an options object.

Related issues and pull requests

In #21531 I'm adding more text to talk about durationThreshold and I've added an example about it on the PerformanceEventTiming page.

@Elchi3 Elchi3 requested a review from a team as a code owner October 14, 2022 13:13
@Elchi3 Elchi3 requested review from sideshowbarker and removed request for a team October 14, 2022 13:13
@github-actions github-actions bot added the Content:WebAPI Web API docs label Oct 14, 2022
@github-actions
Copy link
Contributor

@sideshowbarker sideshowbarker merged commit 8a0113a into mdn:main Oct 16, 2022
@Elchi3 Elchi3 deleted the durationThreshold branch October 16, 2022 09:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Content:WebAPI Web API docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants