Rewrite Error.p.stack

[Josh-Cena]

Fix #30906

[github-actions]

Preview URLs

• /en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack

External URLs (4)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/stack
Title: Error.prototype.stack

• https://firefox-source-docs.mozilla.org/devtools-user/debugger/how_to/debug_eval_sources/index.html (1 time) (Note! This may be a new URL 👀)
• https://fitzgeraldnick.com/2014/12/05/name-eval-scripts.html (1 time) (Note! This may be a new URL 👀)
• https://github.com/tc39/proposal-error-stacks (1 time) (Note! This may be a new URL 👀)
• https://v8.dev/docs/stack-trace-api (2 times) (Note! This may be a new URL 👀)

(comment last updated: 2023-12-12 08:20:38)

[chrisdavidmills]

@Josh-Cena thanks for the great work on this! It mostly makes sense; I have left a few suggestions for you to consider.

[sidewayss]

I just came across a case where Chrome does leaves stack undefined: the clipboard. Can't create a fiddle/pen/playground because reproducing it requires setting a breakpoint on the first line of this block. That shifts focus away from the page during the copy operation, causing an error. Once it breaks, you step line-by-line (F10) a couple of times until the error is caught:

navigator.clipboard.writeText(txt)
    .then (()  => /* insert code here */; )
    .catch(err => alert(`Copy failed: ${err.stack ?? err}`));

Note the end of the last line where I fall back to err.toString() when err.stack is undefined. I just added that bit because of this behavior. Firefox does define stack here (though it's only one line deep). So would this be a Chrome bug, or simply a side-effect of not having a standard in place?

[teoli2003]

Note that the Clipboard is a weird beast as, in Webidl, it isn't an interface but a namespace. No surprise something strange is happening with it.

[Josh-Cena]

So would this be a Chrome bug, or simply a side-effect of not having a standard in place?

More likely a bug. But the only way to tell is by sending an issue and getting their reply.

[sidewayss]

Chrome bug for clipboard error: https://bugs.chromium.org/p/chromium/issues/detail?id=1510545

[chrisdavidmills]

OK, updates look good, so I'm setting this to approved. Nice work @Josh-Cena!

There are just a couple more comments from me for you to check out, and a couple of updated suggestions for you to review. After that we can merge.

[Josh-Cena]

LGTM

[bsmth]

Thanks, all! Shall we merge this one?

[chrisdavidmills]

Thanks, all! Shall we merge this one?

Yussssss ;-)

[sidewayss]

Chrome bug for clipboard error: https://bugs.chromium.org/p/chromium/issues/detail?id=1510545

fyi - this bug is fixed and heading for release in Chrome 122. One less gap in the support for Error.prototype.stack.

[Josh-Cena]

Great to know!

[sidewayss]

Just got Chrome 122 and tested it to confirm that it contains the bug fix.