Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(workflows): assign explicit permissions #38017

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Feb 7, 2025

Description

Assign explicit workflow permissions, to adhere to the principle of least privilege, and document what they're needed for.

Motivation

Resolves 23 CodeQL code scanning alerts.

Additional details

Related issues and pull requests

Related:

@caugner caugner requested a review from a team as a code owner February 7, 2025 09:25
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Feb 7, 2025
Also documents what they are used for.
@caugner caugner force-pushed the workflow-permissions branch from c9f096d to 5ed8dab Compare February 7, 2025 09:27
@caugner caugner requested a review from bsmth February 7, 2025 09:28
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also LGTM, thanks 👍🏻

@caugner caugner merged commit 7b40f15 into main Feb 7, 2025
19 of 20 checks passed
@caugner caugner deleted the workflow-permissions branch February 7, 2025 10:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants