fix typos #38186
fix typos #38186
Conversation
Josh-Cena
requested review from
wbamberg,
estelle and
pepelsbey
and removed request for
a team
github-actions
bot
added
Content:CSS
| @@ -267,6 +271,7 @@ screenleft-screentop | |||
| Scrupulum | |||
| seakale | |||
| serverstart | |||
| shhhh | |||
There was a problem hiding this comment.
| shhhh |
The shhhh is a wrong spelling of sh. I think hush or shush are the correct words for the context.
There was a problem hiding this comment.
Uhhhh... "Shhhh" is a common way to express an elongated "sh". Like "Uhhhhh" or "ahhhhh" are the same as "uh" or "ah".
There was a problem hiding this comment.
But how many h is the standard? Or any number of 'h' is acceptable: shh, shhh, shhhh, or sh+?
I am not trying to be critical here merge as you see fit.
There was a problem hiding this comment.
Any "h" is acceptable. I don't think we use it a lot anyway, but I'm okay to use sh+ here.
There was a problem hiding this comment.
I'm okay to use
sh+here.
Is this kind of pattern supported? I thought we were limited to hardcoded string values
There was a problem hiding this comment.
I don't think that's valid in a custom dictionary. sh+ means "it must be combined with another word as a prefix to be valid". I can move it to the ignored patterns though, if so desired; I just don't think it's common enough.
There was a problem hiding this comment.
I can move it to the ignored patterns though, if so desired; I just don't think it's common enough.
No I think we're good, thanks 👍🏻
|
@bsmith, if this has stalled because of my comment, then the changes look good to me. |
Fix #38185