Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix typos #38398

Merged
merged 3 commits into from
Mar 3, 2025
Merged

fix typos #38398

merged 3 commits into from
Mar 3, 2025

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from a team as code owners March 3, 2025 09:12
@OnkarRuikar OnkarRuikar requested review from estelle, wbamberg, jpmedley and bsmth and removed request for a team March 3, 2025 09:12
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:HTML Hypertext Markup Language docs Content:WebExt WebExtensions docs Content:WebAPI Web API docs Content:Learn Learning area docs Content:Glossary Glossary entries Content:Firefox Content in the Mozilla/Firefox subtree Content:Meta Content in the meta docs system [PR only] Infrastructure and configuration for the project size/m [PR only] 51-500 LoC changed labels Mar 3, 2025
@OnkarRuikar OnkarRuikar changed the title test fix typos Mar 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025 •
edited
Loading

Preview URLs (15 pages)
Flaws (20)

Note! 10 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Glossary/Leading
Title: Leading
Flaw count: 1

  • macros:
    • Macro produces link /en-US/docs/Glossary//Baseline/Typography which is a redirect

URL: /en-US/docs/Mozilla/Firefox/Releases/136
Title: Firefox 136 for developers
Flaw count: 12

  • broken_links:
    • /en-US/docs/Web/API/document/referrer is ill cased
    • /en-US/docs/Glossary/asynchronous is ill cased
    • /en-US/docs/Web/API/document/cookie is ill cased
    • /en-US/docs/Web/URI/Schemes/data is a redirect
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/linear-gradient which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/conic-gradient which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/radial-gradient which is a redirect
    • Macro produces link /en-US/docs/Web/API/document/referrer which is a redirect
    • Macro produces link /en-US/docs/Glossary/asynchronous which is a redirect
    • and 3 more flaws omitted

URL: /en-US/docs/Web/HTML/Element/input/time
Title: <input type="time">
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/user_agent is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/user_agent which is a redirect

URL: /en-US/docs/Web/HTML/Element/pre
Title: <pre>: The Preformatted Text element
Flaw count: 2

  • broken_links:
    • /en-US/docs/Glossary/character_reference is ill cased
  • macros:
    • Macro produces link /en-US/docs/Glossary/character_reference which is a redirect

URL: /en-US/docs/Web/CSS/text-edge
Title: <text-edge>
Flaw count: 3

  • broken_links:
    • /en-US/docs/Glossary/enumerated is ill cased
    • /en-US/docs/Web/CSS/CSS_Types is a redirect
  • macros:
    • Macro produces link /en-US/docs/Glossary/enumerated which is a redirect
External URLs (1)

URL: /en-US/docs/Mozilla/Firefox/Releases/136
Title: Firefox 136 for developers

(comment last updated: 2025-03-03 16:39:19)

bsmth
bsmth approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

@OnkarRuikar
Copy link
Contributor Author

Thank you! LGTM!

I typed the Eiffel Tower calligram by hand, it would be the first in text form on the internet. 😁

rebloor
rebloor approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@rebloor rebloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For web extension changes

Josh-Cena
Josh-Cena reviewed Mar 3, 2025
View reviewed changes
files/en-us/web/html/element/pre/index.md
Comment on lines +24 to +41
S
A
LUT
M
O N
D E
DONT
E SUIS
LA LAN
G U E É
L O Q U E N
TE QUESA
B O U C H E
O P A R I S
T I R E ET TIRERA
T O U JOURS
AUX A L
LEM ANDS - Apollinaire
Copy link
Member

@Josh-Cena Josh-Cena Mar 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity did you typeset this yourself? (nvm I see you said so above) Also why choose another poem?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many wouldn't recognize the earlier shape. I can't. @Josh-Cena What was it?
The tower is well known and more recognizable. It will save people from googling Apollinaire, figuring out what a calligram is, and spending time figuring out the shape.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The poem is about "Le cravate", so it's a tie 😄 The decision makes sense to me.

@Josh-Cena
Copy link
Member

Going to merge this for now. Thanks!

I would prefer all words that are actually intended to stay that way. This includes "livin'", "romcoms", etc.

@Josh-Cena Josh-Cena merged commit b6dacb9 into mdn:main Mar 3, 2025
9 checks passed
@OnkarRuikar OnkarRuikar deleted the ci_typos branch March 5, 2025 02:02
@OnkarRuikar
Copy link
Contributor Author

I would prefer all words that are intended to stay that way. This includes "livin'", "romcoms", etc.

I think breaking it down would make it easily understandable. Google doesn't return much for exact "romcom" word. Also, never heard of aliens getting cute with humans. :D

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@estelle estelle estelle left review comments

@Josh-Cena Josh-Cena Josh-Cena left review comments

@rebloor rebloor rebloor approved these changes

@bsmth bsmth bsmth approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@jpmedley jpmedley Awaiting requested review from jpmedley jpmedley is a code owner automatically assigned from mdn/yari-content-mozilla-add-ons

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Glossary Glossary entries Content:HTML Hypertext Markup Language docs Content:Learn Learning area docs Content:Meta Content in the meta docs Content:WebAPI Web API docs Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Weekly spelling check
5 participants
@OnkarRuikar @Josh-Cena @estelle @rebloor @bsmth