-
Notifications
You must be signed in to change notification settings - Fork 22.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Edit article on HTMLDialogElement open attribute #38532
Edit article on HTMLDialogElement open attribute #38532
Conversation
A boolean value representing the state of the [`open`](/en-US/docs/Web/HTML/Element/dialog#open) HTML attribute. `true` means it is set, and therefore the dialog | ||
is shown. `false` means it not set, and therefore the dialog is not shown. | ||
A boolean value representing the state of the [`open`](/en-US/docs/Web/HTML/Element/dialog#open) HTML attribute. A value of `true` means that the dialog is showing, while `false` means it's not showing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes here are technically beyond the scope of the original issue, but I felt that the original wording was a bit verbose and inaccurate (both true
and false
are technically "set" values). Is this okay or should I split these changes into a separate issue/PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including that in this PR is preferred
Preview URLs Flaws (4)Note! 1 document with no flaws that don't need to be listed. 🎉 URL:
External URLs (1)URL:
(comment last updated: 2025-03-08 22:46:58) |
Co-authored-by: Joshua Chen <sidachen2003@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks :)
Thanks! |
Description
open
attribute reflectsMotivation
See linked issue #38508
Additional details
Related issues and pull requests
Fixes #38508