simplify WritableStream example #38536
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Content:WebAPI
|
Preview URLs |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The example is needlessly complex. It converts a string to a
Uint8Array, then writes each byte of the array separately, and reconstructs the message later. It could simply send the string. Streams are confusing enough. The examples shouldn't add to that.Motivation
I want developers to be able to understand essential concepts of streams and JavaScript clearly.
Additional details
The example refers to the bytes within a
Uint8Arrayas "chunks". They are just numbers. This is confusing. The confusion is eliminated by simply writing the message as a string to the stream.