Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(css): consistent naming for function-like pseudo-classes #865

Merged
merged 3 commits into from
Dec 30, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 29, 2024

Description

consistent naming for function-like pseudo-classes

Motivation

Additional details

Related issues and pull requests

Fixes #242

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 29, 2024 05:17
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 29, 2024 05:18
@skyclouds2001 skyclouds2001 requested review from bsmth and removed request for a team December 29, 2024 05:18
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. These all make sense to me. I wonder if we need to update the titles in the ::view-transition-* docs in mdn/content because I agree the syntax is function-like. Also:

https://developer.mozilla.org/en-US/docs/Web/API/View_Transition_API#pseudo-elements

@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Dec 30, 2024

These all make sense to me. I wonder if we need to update the titles in the ::view-transition-* docs in mdn/content because I agree the syntax is function-like.

yes, I think the same thing should be done in mdn/content

@bsmth bsmth merged commit 8d17ec8 into mdn:main Dec 30, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the function-like-pseudo-class branch December 30, 2024 18:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent naming for pseudo-classes that act as functions
2 participants