Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(filechecker): revert imagemin-svgo #11201

Merged
merged 2 commits into from
May 27, 2024
Merged

fix(filechecker): revert imagemin-svgo #11201

merged 2 commits into from
May 27, 2024

Conversation

fiji-flo
Copy link
Contributor

Summary

Update is braking the filechecker.

See: imagemin/imagemin-svgo#62

Problem

       TypeError: Expected a `string`, got `object`
           at isSvg (file:///Users/…/github/yari/node_modules/is-svg/index.js:5:9)
           at file:///Users/…/github/yari/node_modules/imagemin-svgo/index.js:11:7
           at file:///Users/…/github/yari/node_modules/p-pipe/index.js:10:25
           at handleFile (file:///Users/…/github/yari/node_modules/imagemin/index.js:17:54)
           at async file:///Users/…/github/yari/node_modules/imagemin/index.js:54:13
           at async Promise.all (index 0)
           at async checkCompression (file:///Users/…/github/yari/filecheck/checker.ts:146:23)
           at async checkFile (file:///Users/…/github/yari/filecheck/checker.ts:126:5)
           at async file:///Users/…/github/yari/filecheck/checker.ts:215:13

Solution

Downgrade and ignore in dependabot.

@fiji-flo fiji-flo requested a review from wbamberg May 27, 2024 15:44
@fiji-flo fiji-flo requested review from mdn-bot and a team as code owners May 27, 2024 15:44
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 27, 2024
@caugner caugner merged commit bd4aad4 into mdn:main May 27, 2024
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants