Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Sort default components #2318

Merged
merged 3 commits into from
Jul 4, 2023
Merged

Sort default components #2318

merged 3 commits into from
Jul 4, 2023

Conversation

remcohaszing
Copy link
Member

This makes the output a bit more predictable.

@remcohaszing
Sort default components
cb427e2 
This makes the output a bit more predictable.
@remcohaszing remcohaszing added 🦋 type/enhancement This is great to have 🏡 area/internal This affects the hidden internals 👶 semver/patch This is a backwards-compatible fix 🤞 phase/open Post is being triaged manually labels Jun 28, 2023
@remcohaszing remcohaszing requested a review from wooorm June 28, 2023 08:54
@vercel
Copy link

vercel bot commented Jun 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 4, 2023 11:57am

@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7504cfb) 100.00% compared to head (b40bd1f) 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main     #2318   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2177      2183    +6     
=========================================
+ Hits          2177      2183    +6
Impacted Files Coverage Δ
packages/mdx/lib/plugin/recma-jsx-rewrite.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@wooorm
Copy link
Member

wooorm commented Jun 28, 2023

  • Why only tags?
  • a direct sort, because it mutates and returns, always seems a bit finicky to me, maybe a const tags = [...scope.tags].sort()?

@remcohaszing
Copy link
Member Author

  • What more than tags?
  • It’s mutating a variable that only exists in the local scope, so I figured it’s ok. I can create a shallow copy if you still think that’s better.

@wooorm
Copy link
Member

wooorm commented Jun 28, 2023

There’s also objects, components, and idToInvalidComponentName in scope. references is already sorted it looks like!

I can create a shallow copy if you still think that’s better.

Yeah I think it‘s slightly better, but it’s mostly theoretical yeah

@remcohaszing
Copy link
Member Author

I decided to sort the actual array, which is where objects, and components end up.

I also noticed some of these arrays contain unique values, so they would ideally be sets instead of arrays.

@wooorm wooorm merged commit 825717f into main Jul 4, 2023
@wooorm wooorm deleted the sort-components branch July 4, 2023 12:00
@wooorm wooorm added 💪 phase/solved Post is done and removed 🤞 phase/open Post is being triaged manually labels Jul 4, 2023
@wooorm
Copy link
Member

wooorm commented Jul 4, 2023

Thanks! :)

kodiakhq bot referenced this pull request in X-oss-byte/Nextjs Oct 24, 2023
@renovate
Update mdx monorepo to v3 (major) (#523)
74bd917 
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@mdx-js/loader](https://mdxjs.com) ([source](https://github.com/mdx-js/mdx)) | [`2.3.0` -> `3.0.0`](https://renovatebot.com/diffs/npm/@mdx-js%2floader/2.3.0/3.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mdx-js%2floader/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mdx-js%2floader/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mdx-js%2floader/2.3.0/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mdx-js%2floader/2.3.0/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |
| [@mdx-js/react](https://mdxjs.com) ([source](https://github.com/mdx-js/mdx)) | [`2.3.0` -> `3.0.0`](https://renovatebot.com/diffs/npm/@mdx-js%2freact/2.3.0/3.0.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@mdx-js%2freact/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@mdx-js%2freact/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@mdx-js%2freact/2.3.0/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@mdx-js%2freact/2.3.0/3.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>mdx-js/mdx (@&#8203;mdx-js/loader)</summary>

### [`v3.0.0`](https://github.com/mdx-js/mdx/releases/tag/3.0.0)

[Compare Source](https://github.com/mdx-js/mdx/compare/2.3.0...3.0.0)

(see <https://mdxjs.com/migrating/v3/> on how to migrate)

##### Change

-   [`e08b759`](https://github.com/mdx-js/mdx/commit/e08b7596) [`5afa48e`](https://github.com/mdx-js/mdx/commit/5afa48e6) Change to require Node 16
-   [`5a13d73`](https://github.com/mdx-js/mdx/commit/5a13d73b) Change to use export maps
-   [`cbc2822`](https://github.com/mdx-js/mdx/commit/cbc2822f) Update `unified`, types, plugins, etc
-   [`96b51f9`](https://github.com/mdx-js/mdx/commit/96b51f93) Remove inferral of development from `NODE_ENV`

##### Change (unlikely to affect you)

-   [`c961af8`](https://github.com/mdx-js/mdx/commit/c961af80) Remove `useDynamicImport` option
-   [`9cb26fd`](https://github.com/mdx-js/mdx/commit/9cb26fd1) `@mdx-js/register`: remove package
-   [`0d1558a`](https://github.com/mdx-js/mdx/commit/0d1558a3) `@mdx-js/esbuild`: remove experimental `allowDangerousRemoteMdx`
-   [`0f62bce`](https://github.com/mdx-js/mdx/commit/0f62bce9) `@mdx-js/node-loader`: remove `fixRuntimeWithoutExportMap`
-   [`4f92422`](https://github.com/mdx-js/mdx/commit/4f924227) `@mdx-js/preact`: remove deprecated `MDXContext`, `withMDXComponents`
-   [`a362bb4`](https://github.com/mdx-js/mdx/commit/a362bb43) `@mdx-js/react`: remove deprecated `MDXContext`, `withMDXComponents`

##### Add

-   [`e12f307`](https://github.com/mdx-js/mdx/commit/e12f3079) Add support for passing `baseUrl` when running
-   [`2c511a4`](https://github.com/mdx-js/mdx/commit/2c511a40) Add support for `baseUrl` as a `URL`
-   [`1863914`](https://github.com/mdx-js/mdx/commit/1863914c) Add deprecation warning for classic runtime
-   [`a34177c`](https://github.com/mdx-js/mdx/commit/a34177c3) Add support for ES2024 in MDX, adjacent JSX and expression blocks
-   [`44fd9ca`](https://github.com/mdx-js/mdx/commit/44fd9cac) Add support for `await` in MDX
-   [`3a7f194`](https://github.com/mdx-js/mdx/commit/3a7f1947) Add `tableCellAlignToStyle` option, to use `align`
-   [`fdfe17b`](https://github.com/mdx-js/mdx/commit/fdfe17b8) `@mdx-js/rollup`: add support for Vite development mode
    by [@&#8203;remcohaszing](https://github.com/remcohaszing) in [https://github.com/mdx-js/mdx/pull/2376](https://github.com/mdx-js/mdx/pull/2376)

##### Misc

-   [`f48d038`](https://github.com/mdx-js/mdx/commit/f48d038b) Remove unneeded pragma comment after transform
-   [`8f3b292`](https://github.com/mdx-js/mdx/commit/8f3b2920) Add a `use strict` directive to function bodies
-   [`172e519`](https://github.com/mdx-js/mdx/commit/172e5190) `@mdx-js/react`: fix to classify `@types/react` as a peer dependency
    by [@&#8203;remcohaszing](https://github.com/remcohaszing) in [https://github.com/mdx-js/mdx/pull/2281](https://github.com/mdx-js/mdx/pull/2281)
-   [`a7bd79b`](https://github.com/mdx-js/mdx/commit/a7bd79bb) Refactor output to immediately export default
-   [`e525db9`](https://github.com/mdx-js/mdx/commit/e525db9b) [`dae82ae`](https://github.com/mdx-js/mdx/commit/dae82ae4) Refactor some errors
-   [`ce173f2`](https://github.com/mdx-js/mdx/commit/ce173f28) Refactor to add types for JSX runtimes
-   [`8a56312`](https://github.com/mdx-js/mdx/commit/8a563128) Refactor output to use spread, not `Object.assign`
    by [@&#8203;remcohaszing](https://github.com/remcohaszing) in [https://github.com/mdx-js/mdx/pull/2328](https://github.com/mdx-js/mdx/pull/2328)
-   [`825717f`](https://github.com/mdx-js/mdx/commit/825717fd) Refactor to sort default components
    by [@&#8203;remcohaszing](https://github.com/remcohaszing) in [https://github.com/mdx-js/mdx/pull/2318](https://github.com/mdx-js/mdx/pull/2318)
-   [`d8a62d2`](https://github.com/mdx-js/mdx/commit/d8a62d20) Add missing type dependencies
    by [@&#8203;arcanis](https://github.com/arcanis) in [https://github.com/mdx-js/mdx/pull/2256](https://github.com/mdx-js/mdx/pull/2256)

##### Docs

-   [`a9f0c04`](https://github.com/mdx-js/mdx/commit/a9f0c046) Add guide on injecting components
-   [`24e3d8d`](https://github.com/mdx-js/mdx/commit/24e3d8d1) Add compat sections to readmes
-   [`30e4a5d`](https://github.com/mdx-js/mdx/commit/30e4a5d5) Add sponsor
-   [`07503a5`](https://github.com/mdx-js/mdx/commit/07503a5f) Update link to KaTeX CSS in docs
    by [@&#8203;victor23k](https://github.com/victor23k) in [https://github.com/mdx-js/mdx/pull/2360](https://github.com/mdx-js/mdx/pull/2360)
-   [`74aee56`](https://github.com/mdx-js/mdx/commit/74aee569) [`bc1d9e5`](https://github.com/mdx-js/mdx/commit/bc1d9e56) [`765310c`](https://github.com/mdx-js/mdx/commit/765310ca) [`6d1e64d`](https://github.com/mdx-js/mdx/commit/6d1e64d9) Refactor docs
-   [`7fd1d9a`](https://github.com/mdx-js/mdx/commit/7fd1d9a4) Fix docs on how to use solid
    by [@&#8203;BeiyanYunyi](https://github.com/BeiyanYunyi) in [https://github.com/mdx-js/mdx/pull/2300](https://github.com/mdx-js/mdx/pull/2300)
-   [`4129f90`](https://github.com/mdx-js/mdx/commit/4129f90e) Fix a couple typos
    by [@&#8203;deining](https://github.com/deining) in [https://github.com/mdx-js/mdx/pull/2266](https://github.com/mdx-js/mdx/pull/2266)
-   [`bb902f8`](https://github.com/mdx-js/mdx/commit/bb902f83) Fix typo
    by [@&#8203;ChristianMurphy](https://github.com/ChristianMurphy) in [https://github.com/mdx-js/mdx/pull/2380](https://github.com/mdx-js/mdx/pull/2380)

##### Site

-   [`78a1eb5`](https://github.com/mdx-js/mdx/commit/78a1eb52) Add v3 blog post
-   [`2b1948c`](https://github.com/mdx-js/mdx/commit/2b1948c0) Add v3 migration guide
-   [`d6bb70c`](https://github.com/mdx-js/mdx/commit/d6bb70ca) Add improved error display in playground
-   [`89097e4`](https://github.com/mdx-js/mdx/commit/89097e4c) Remove unmaintained dev-dependency
-   [`3e23ba9`](https://github.com/mdx-js/mdx/commit/3e23ba90) Add more options to playground
-   [`d92128b`](https://github.com/mdx-js/mdx/commit/d92128ba) Fix links in docs
-   [`ab3aa96`](https://github.com/mdx-js/mdx/commit/ab3aa966) Add GitHub pages
    by [@&#8203;remcohaszing](https://github.com/remcohaszing) in [https://github.com/mdx-js/mdx/pull/2377](https://github.com/mdx-js/mdx/pull/2377)
-   [`a2c8693`](https://github.com/mdx-js/mdx/commit/a2c86936) Fix site
    by [@&#8203;wooorm](https://github.com/wooorm) in [https://github.com/mdx-js/mdx/pull/2358](https://github.com/mdx-js/mdx/pull/2358)
-   [`dbe9f44`](https://github.com/mdx-js/mdx/commit/dbe9f44b) Fix playground AST views w/ clone
    by [@&#8203;Jokcy](https://github.com/Jokcy) in [https://github.com/mdx-js/mdx/pull/2315](https://github.com/mdx-js/mdx/pull/2315)
-   [`7504cfb`](https://github.com/mdx-js/mdx/commit/7504cfb8) Add more options to playground, directives, format, etc
    by [@&#8203;slorber](https://github.com/slorber) in [https://github.com/mdx-js/mdx/pull/2295](https://github.com/mdx-js/mdx/pull/2295)
-   [`57301df`](https://github.com/mdx-js/mdx/commit/57301dfa) Add resizable editor/layout to playground
    by [@&#8203;slorber](https://github.com/slorber) in [https://github.com/mdx-js/mdx/pull/2296](https://github.com/mdx-js/mdx/pull/2296)
-   [`9eb747d`](https://github.com/mdx-js/mdx/commit/9eb747d6) Add info on how to build site locally
    by [@&#8203;slorber](https://github.com/slorber) in [https://github.com/mdx-js/mdx/pull/2297](https://github.com/mdx-js/mdx/pull/2297)

**Full Changelog**: mdx-js/mdx@2.3.0...3.0.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/X-oss-byte/Nextjs).
@snyk-io snyk-io bot mentioned this pull request May 22, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jun 6, 2024
Open
@rong4ivy rong4ivy mentioned this pull request Jun 8, 2024
Open
@kaelynj kaelynj mentioned this pull request Jun 14, 2024
Merged
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 20, 2024
Open
@mikegorman-nf mikegorman-nf mentioned this pull request Jun 22, 2024
Merged
@rsaz rsaz mentioned this pull request Jul 6, 2024
Closed
@spudly spudly mentioned this pull request Jul 17, 2024
Merged
@nair0lf32 nair0lf32 mentioned this pull request Jul 17, 2024
Merged
@Billywildhig Billywildhig mentioned this pull request Jul 21, 2024
Open
@InfiniteLove2020 InfiniteLove2020 mentioned this pull request Oct 4, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wooorm wooorm wooorm approved these changes

Assignees
No one assigned
Labels
🏡 area/internal This affects the hidden internals 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@remcohaszing @codecov-commenter @wooorm