#245 Pass environment variables to all sudo commands #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not just "nominatim import" This enables passing NOMINATIM_DATABASE_DSN
|
It just occurred to me that you might want to apply this to other versions too? I'm new to Nominatim so no idea if previous versions have similar env vars. |
|
I you want to do it you can, but we won't force you. I personally only fix stuff in the newest version. |
|
Seems that the Geofabrik download server is having some outage today. https://download.geofabrik.de/europe/monaco-220313.osm.pbf times out and hence CI fails. I will recheck tomorrow. |
|
Thanks for the contribution! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not just "nominatim import"
This enables passing NOMINATIM_DATABASE_DSN
In practice users still have to pass PGDATABASE and the rest of the standard psql env vars separately.
To avoid that the bash script would have to parse NOMINATIM_DATABASE_DSN into the standard Postgres env vars.