Update tools and dependencies #170
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: slintes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
Signed-off-by: Marc Sluiter <msluiter@redhat.com>
| @@ -6,17 +6,17 @@ require ( | |||
| github.com/go-logr/logr v1.2.3 | |||
| github.com/onsi/ginkgo/v2 v2.6.0 | |||
| github.com/onsi/gomega v1.24.1 | |||
| github.com/openshift/api v0.0.0-20221013123531-622889ac07cf | |||
| github.com/openshift/client-go v0.0.0-20211209144617-7385dd6338e3 | |||
| github.com/openshift/api release-4.11 | |||
There was a problem hiding this comment.
Nice :)
IMHO this way (using release-OCP_Y_VERSION instead of long version number) seems easier to read or identify the version.
There was a problem hiding this comment.
well, it's just an intermediate helper., instead of finding out the correct version myself. go mod tidy replaces it with the long version
|
NIT: Can you update the quay image for scorecard tests version as part of upgrading the operator-sdk version? It is quite old (older than a year) and I assume that the newer is more better, and there are three places which use this image (see also from NMO's PR of upgrading the operator-sdk version). |
|
/lgtm |
|
Thx for review. Tbh I have no clue what these scorecard tests are doing. Will check in a follow up. /hold cancel |
Update tools and dependencies, tidy and vendor, update manifests, fix a compile error