Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tracker for xow patches #156

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Tracker for xow patches #156

wants to merge 10 commits into from

Conversation

kakra
Copy link
Contributor

@kakra kakra commented Jan 24, 2021

This PR tracks interesting changes, feel free to cherry-pick important or useful commits.

  • Work around rumble-induced firmware crashes
  • Force clang code formatting for better rebase
  • Make triple-buffer accessor method reentrant
  • Improved systemd logging
  • Code cleanups

atcq and others added 10 commits March 24, 2021 19:13
I encountered the `Mt76Exception: Failed to load firmware` error quite a few times. xow.service is stopped and needs a restart as stated in the Troubleshooting section of the README.md. To make my life easier i added a udev rule to do just that for me when i plugged the dongle back in after uplugging it.
Should start/restart the xow.service if the service is not running or is in a `failed` state due to previous ABRT signal.
I think it would be a simple change to the udev.rules to make that the default behaviour but maybe a manual restart is desired?

Anyways, thanks a lot for your work! I'm quite happy with xow!

Closes: medusalix#153
Signed-off-by: Kai Krakow <kai@kaishome.de>
This reverts commit bec8f35.

Signed-off-by: Kai Krakow <kai@kaishome.de>
Signed-off-by: Kai Krakow <kai@kaishome.de>
Download `git-clang-format` and put it in your path:
https://github.com/llvm-mirror/clang/raw/master/tools/clang-format/git-clang-format

This can be added as a pre-commit hook:

```bash
#!/bin/sh
exec git clang-format
```

Save as `.git/hooks/pre-commit` and `chmod +x` it.

Signed-off-by: Kai Krakow <kai@kaishome.de>
This migrates the early exit in `inputFeedbackReceived` into a common
exit path so we can more easily add a rumble packet throttler.

Signed-off-by: Kai Krakow <kai@kaishome.de>
Signed-off-by: Kai Krakow <kai@kaishome.de>
Signed-off-by: Kai Krakow <kai@kaishome.de>
Signed-off-by: Kai Krakow <kai@kaishome.de>
Signed-off-by: Kai Krakow <kai@kaishome.de>
Copy link

@Galcian79 Galcian79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

d9a4768
Line 6 should be: # start the xow.service on device mount
Just to clarify you don't actually need to plugin the device for it to work. Even plugged in devices are detected and mounted at systemd boot.

@kakra
Copy link
Contributor Author

kakra commented Sep 13, 2021

Just to clarify you don't actually need to plugin the device for it to work

Well, Linux uses the terms cold-plug (synthetic events played back on system boot for device already present) and hot-plug (devices added later) for it, both events are covered by this. Maybe we should use that terminology?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants