Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

support multilingual announcements #1443

Merged
merged 1 commit into from
May 23, 2019
Merged

support multilingual announcements #1443

merged 1 commit into from
May 23, 2019

Conversation

DominikGuzei
Copy link
Contributor

@DominikGuzei DominikGuzei commented May 22, 2019 •
edited
Loading

This PR adds support for multilingual announcements with the following logic:

  1. if the announcement json includes the users locale as root key -> take that
  2. if there is the default locale defined -> take that
  3. If no default locale, treat the announcement as not multilingual and pick root

@DominikGuzei DominikGuzei requested a review from adlk May 22, 2019 15:30
@DominikGuzei DominikGuzei self-assigned this May 22, 2019
adlk
adlk approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@adlk adlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@DominikGuzei DominikGuzei merged commit 1b167e0 into develop May 23, 2019
@DominikGuzei DominikGuzei deleted the feature/multilingual-announcements branch May 23, 2019 10:12
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@adlk adlk adlk approved these changes

Assignees

@DominikGuzei DominikGuzei

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DominikGuzei @adlk