Android: Allow custom background color #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ox-michaelradionov Would it be possible to get this color from the theme? Or something similar declaratively? I'll merge this if that's non-trivial or doesn't make sense to you. |
|
@mehcode I'm not sure if it is possible, I'll check |
|
@mehcode I've updated the PR to use themes as you suggested. |
mehcode
added a commit
that referenced
this pull request
Aug 9, 2017
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds third optional argument to
SplashScreen.show()on Android to allow customization of background color. It is important for me because this color appears for a second when keyboard animation happens (it is displayed when space for keyboard is already reserved but opening animation is still happening).By default white background color is used.
Usage: