Evaluation

1st round

• I think the first 1-2 week the communication was not the best. but after that period it improved a lot, and I could say it is in the right direction:

• You approached me between weekly chats, if there is a blocking issue.
• I got a relevant question about code, functionality.

• The project started slowly, and I think in order to finish there should be a boost. But I think generally the development somewhat accelerated since the communication improved.

---

2nd round

Communication:

The good examples would be still the same:

• You ask the relevant questions.
• You are punctual on the meeting we agreed upon.

There are bad examples:

• Sometimes you seem to forget things we discussed and ask them again. For example: what a method of a class shall do?

• Don't get me wrong, it is better to ask again. But I do not know if you make notes about those.
• I usually use a notebook, but temporary comments in the code are also good.

Tooling, methods:

• I think during this development period you were only exposed to the gdb, which I think you could use. I would suggest you polish your gdb skills.
• When we had a discussion about testing, I think you have a general idea like most fresh programmers, I would advise you to study TDD(Test-driven development).

Coding:

• I see that you could use the developer documentation (hiredis, redis, glib), and does changes based on them.

Good examples:

• change the GStaticMutex into GMutex as the first one is deprecated by glib documentation
• the hiredis is not that clear on when a reply shall be freed (but you got it right)

---

3rd round

• I want to emphasize that the first two evaluation still stands as feedback, and I do not want to repeat them, but also you to forget.

• I think you could improve your skills about the following topics: clean code, SOLID principles, object oriented, KISS principle.

• These topics mostly not something you can learn just by reading or taking some class, and not something that you can learn once and be a master of.

• Those require constant crafting. I would very much recommend discussing such topics and designs with others looking for the better solution, by doing those I think you can learn a lot.

• Sometimes it felt to me that your primary motive was to finish tasks, and not to create something that you could be proud. There should be a time when you feel that something does the job, but it can be better in design or readability.

• I do not know exactly what information is shared, so I wanted to say two things.

• First of all, I think that the current project is not finish, and there are tasks that should be done, there is a lot of learning opportunity.

• The second one that despite this I marked you a pass because I believe that you made an effort on the project and we could continue.