Skip to content

Commit

Permalink
Merge #4462
Browse files Browse the repository at this point in the history
4462: Divide threshold by ten r=dureuill a=ManyTheFish

Change the facet incremental vs bulk indexing threshold to better fit our user needs, it might be changed in the future if we have more insights


Co-authored-by: ManyTheFish <many@meilisearch.com>
  • Loading branch information
meili-bors[bot] and ManyTheFish authored Mar 6, 2024
2 parents ab1224b + eada6de commit ee3076d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion milli/src/update/facet/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ impl<'i> FacetsUpdate<'i> {
self.index.set_updated_at(wtxn, &OffsetDateTime::now_utc())?;

// See self::comparison_bench::benchmark_facet_indexing
if self.data_size >= (self.database.len(wtxn)? / 50) {
if self.data_size >= (self.database.len(wtxn)? / 500) {
let field_ids =
self.index.faceted_fields_ids(wtxn)?.iter().copied().collect::<Vec<_>>();
let bulk_update = FacetsUpdateBulk::new(
Expand Down

0 comments on commit ee3076d

Please # to comment.