Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

DeleteDomainChecksumsChangesetIntegrationTest fails in some environments #290

Closed
mseaton opened this issue Jan 30, 2025 · 2 comments
Closed

Comments

@mseaton
Copy link
Collaborator

mseaton commented Jan 30, 2025

Trying to build the module from latest today, I consistently ran into a test failure with the DeleteDomainChecksumsChangesetIntegrationTest test.

Investigating this a little bit, I believe this is due to a dirtied context that affects the conditions this test needs to execute, as this test passes on it's own and currently passes on github actions, but fails in my local environment.

My suspicion is that this class depends on some specific LIQUIBASECHANGELOG and LIQUIBASECHANGELOGLOCK tables existing, yet there are some tests that create and delete these tables within the context, namely the teardown method of LiquibaseLoader25IntegrationTest which runs:

	@After
	public void teardown() {
		adminService.executeSQL("drop table LIQUIBASECHANGELOG", false);
		adminService.executeSQL("drop table LIQUIBASECHANGELOGLOCK", false);
	}
mseaton added a commit to mseaton/openmrs-module-initializer that referenced this issue Jan 30, 2025
@mseaton
Copy link
Collaborator Author

mseaton commented Jan 30, 2025

PR here: #291
Not really the most elegant solution, and doesn't really address the underlying issue, but it does fix things.

@mseaton
Copy link
Collaborator Author

mseaton commented Jan 31, 2025

Committed, see above. Thanks @Ruhanga

@mseaton mseaton closed this as completed Jan 31, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant