[#257] Provision to allow overriding concepts' datatype to 'Numeric'. #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Code here looks good, but I'm a little hesitant about the process described in the ticket. In particular, if a concept has the wrong datatype, the right way to handle that is to retire the concept with the wrong datatype and create a new concept with the right datatype, rather than simply changing the existing concept.
|
I agree especially if the concept was already in use by some Obs. There are those cases however where concepts can have their datatypes changed. We have this check here that enforces validity to change a concept's datatype. |
mseaton
approved these changes
Dec 7, 2023
mks-d
changed the title
mks-d
changed the title
mks-d
approved these changes
Dec 7, 2023
Ruhanga
added a commit
that referenced
this pull request
Dec 8, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #257