Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix for "Invalid child context type 'virtualizedCell.cellKey'" #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

schmoove
Copy link

No description provided.

@slorber
Copy link

slorber commented Apr 19, 2018

this PR seems fine, small and safe. Can it be merged and released?

@geastwood
Copy link

This PR fix the warning, can we merge this please?

@tavriaforever
Copy link

@Exilz Hi! Could you merge this PR?

Copy link

@mahdikhosravi mahdikhosravi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is OK! Please accept it

@fzyzcjy
Copy link

fzyzcjy commented Jul 12, 2018

+1

@schmoove
Copy link
Author

schmoove commented Aug 4, 2018

Could an admin merge this please - I just reinstalled the lib and was surprised to get the same error after all this time! Thx :)

@AndrewSouthpaw
Copy link

@konkissner
Copy link

+1

@alexandrecanuto
Copy link

If anyone's interested, I've forked this repo fixing this and adding a maxScale option. https://github.com/ever-digital/react-native-image-gallery

@shiftrtech
Copy link

shiftrtech commented Oct 20, 2018

If anyone's interested, I've forked this repo fixing this and adding a maxScale option. https://github.com/ever-digital/react-native-image-gallery

yarn remove react-native-image-gallery

yarn add https://github.com/ever-digital/react-native-image-gallery.git#master

@alexandrecanuto thanks.

@jstarw
Copy link

jstarw commented Mar 9, 2019

Can this be merged please? It's been over a year

@sungsong88
Copy link

Please! Please merge this! 🙏

@migueldaipre
Copy link

Please merge this!

@peckpeck20
Copy link

@Exilz @bd-arc if its safe to merge, please do :)

@dimgrav
Copy link

dimgrav commented Jul 23, 2019

Why is this still not merged!?

@geirman
Copy link

geirman commented Jul 23, 2019

@dimgrav probably because the Archriss has more profitable or more interesting things to do with his limited time? This repo hasn't been active for a while. Maybe you can volunteer to take it over? Or fork it and start maintaining your own fork. The beauty of OSS is you always have options.

@dimgrav
Copy link

dimgrav commented Jul 23, 2019

@geirman I was actually ready to make a PR to the Mattermost fork, but saw that this is pending, so I thought I'd give it a shout.

@NTKrieger
Copy link

NTKrieger commented May 27, 2021

yarn remove react-native-image-gallery

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.