Skip to content

Commit

Permalink
Fix annotation for SQLTarget.append_builtin_config
Browse files Browse the repository at this point in the history
  • Loading branch information
edgarrmondragon committed Nov 9, 2022
1 parent 6aafeaf commit 601c5e2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 18 deletions.
16 changes: 0 additions & 16 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions singer_sdk/target_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -589,7 +589,7 @@ def capabilities(self) -> list[CapabilitiesEnum]:
return sql_target_capabilities

@classmethod
def append_builtin_config(self, config_jsonschema: dict) -> None: # noqa: ANN102
def append_builtin_config(cls: type[SQLTarget], config_jsonschema: dict) -> None:
"""Appends built-in config to `config_jsonschema` if not already set.
To customize or disable this behavior, developers may either override this class
Expand All @@ -611,7 +611,7 @@ def _merge_missing(source_jsonschema: dict, target_jsonschema: dict) -> None:
if k not in target_jsonschema["properties"]:
target_jsonschema["properties"][k] = v

capabilities = self.capabilities
capabilities = cls.capabilities

if TargetCapabilities.TARGET_SCHEMA in capabilities:
_merge_missing(TARGET_SCHEMA_CONFIG, config_jsonschema)
Expand Down

0 comments on commit 601c5e2

Please # to comment.