-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
chore: Add support for python 3.11 #1115
chore: Add support for python 3.11 #1115
Conversation
Hey @laurentS! You'll need to add - python_versions = ["3.10", "3.9", "3.8", "3.7"]
+ python_versions = ["3.11", "3.10", "3.9", "3.8", "3.7"] Even then, I'm not sure it'll work because of our (dev) dependency on Numpy. The older version we pull may not have wheels for 3.11 or not even support it at all, and we can't bump Numpy until we drop support for 3.7 🤷♂️ |
Ok, it looks liks |
Agreed we can probably wait this out if Since To my knowledge (and with a quick search to confirm), this is the only place where the sdk/samples/sample_target_parquet/parquet_target_sink.py Lines 7 to 8 in 6adeead
|
I'm wondering if these dependencies that are only used for samples would be better managed as |
@laurentS Poetry would still resolve those dependencies along with the rest even if they're extras. The samples would need their own separate dependency trees/ |
Codecov Report
@@ Coverage Diff @@
## main #1115 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 42 42
Lines 3854 3854
Branches 657 657
=======================================
Hits 3218 3218
Misses 472 472
Partials 164 164 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm seeing 2 packages that cause problems with python 3.11:
At this point, all checks are green, with a bit of a caveat for 3.11. I had to adjust dependency specifications for older pythons, as newer releases came out recently that broke tests. |
|
@laurentS Sounds good. Skipping the test on 3.11 is a good approach 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the latest updates, this is looking good to me. 👍
Thanks very much.
Alright @laurentS, this LGTM! Thanks so much for making all the necessary updates in tests and dependencies. |
This just adds a few lines to run CI tests on the recently released python 3.11.
Substantial speedups are expected, and as the taps and targets are run inside their own virtual envs, it should be pretty easy to upgrade them even if the main app is running on an earlier version of python.
📚 Documentation preview 📚: https://meltano-sdk--1115.org.readthedocs.build/en/1115/