Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove tox dependency from tap/target template #1345

Merged
merged 1 commit into from
Jan 24, 2023
Merged

fix: Remove tox dependency from tap/target template #1345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cookiecutter/tap-template/{{cookiecutter.tap_id}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ requests = "^2.28.1"

[tool.poetry.group.dev.dependencies]
pytest = "^7.2.0"
tox = "^4.1.3"
flake8 = "^3.9.2"
black = "^22.12.0"
pydocstyle = "^6.2.1"
Expand Down
1 change: 0 additions & 1 deletion cookiecutter/target-template/{{cookiecutter.target_id}}/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ requests = "^2.28.1"

[tool.poetry.dev-dependencies]
pytest = "^7.2.0"
tox = "^4.1.3"
flake8 = "^3.9.2"
black = "^22.12.0"
pydocstyle = "^6.2.1"
Expand Down
10 changes: 7 additions & 3 deletions docs/dev_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,20 @@ for more information on differences between a target's `Sink` class versus a tap

## Building a New Tap or Target

First, install [cookiecutter](https://cookiecutter.readthedocs.io) if you haven't
done so already:
First, install [cookiecutter](https://cookiecutter.readthedocs.io),
[Poetry](https://python-poetry.org/docs/), and optionally [Tox](https://tox.wiki/):

```bash
# Install pipx if you haven't already
pip3 install pipx
pip install pipx
pipx ensurepath

# Restart your terminal here, if needed, to get the updated PATH
pipx install cookiecutter
pipx install poetry

# Optional: Install Tox if you want to use it to run auto-formatters, linters, tests, etc.
pipx install tox
```

Now you can initialize your new project with the Cookiecutter template for taps:
Expand Down
9 changes: 1 addition & 8 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.