Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(taps): Check replication method instead of key to determine if a SQL stream is sorted #2418

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 8, 2024

Copy link

codspeed-hq bot commented May 8, 2024

CodSpeed Performance Report

Merging #2418 will not alter performance

Comparing 2078/edgarrmondragon/fix/check-replication-method (88e9391) with main (5eb1235)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.47%. Comparing base (5eb1235) to head (88e9391).
Report is 125 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2418   +/-   ##
=======================================
  Coverage   89.47%   89.47%           
=======================================
  Files          58       58           
  Lines        4799     4799           
  Branches      937      937           
=======================================
  Hits         4294     4294           
  Misses        352      352           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2078/edgarrmondragon/fix/check-replication-method branch from ace1d61 to d6c4b77 Compare May 15, 2024 20:40
@edgarrmondragon edgarrmondragon force-pushed the 2078/edgarrmondragon/fix/check-replication-method branch 2 times, most recently from fc7aa81 to 1223647 Compare May 27, 2024 22:11
@edgarrmondragon edgarrmondragon force-pushed the 2078/edgarrmondragon/fix/check-replication-method branch from 1223647 to b702fe8 Compare July 2, 2024 20:23
@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 30, 2024 19:10
@edgarrmondragon edgarrmondragon merged commit cb163bf into main Jul 30, 2024
36 checks passed
@edgarrmondragon edgarrmondragon deleted the 2078/edgarrmondragon/fix/check-replication-method branch July 30, 2024 19:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant