Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow custom orchard inject string #3

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Allow custom orchard inject string #3

merged 2 commits into from
Jun 13, 2022

Conversation

terodox
Copy link
Contributor

@terodox terodox commented Jun 13, 2022

Thanks for opening a Pull Request

Changes

Please outline the reason for the changes you are making:

  • Adding a cli option to provide a custom string that will be replaced by script tags
    • Allows for customizability and eliminated potential conflicts

Are there any breaking changes you are aware of in the PR?

No

General Checklist

  • Change is tested locally
  • Demo is updated to exercise change (if applicable)
  • [WIP] flag is removed from the title

@terodox terodox requested a review from a team as a code owner June 13, 2022 14:44
@terodox terodox merged commit 8b010f8 into main Jun 13, 2022
@terodox terodox deleted the allow-custom-orchard-inject-string branch June 13, 2022 14:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@terodox