Support for resetting fallback fonts. #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memononen
reviewed
Feb 28, 2020
src/fontstash.h
Outdated
| @@ -797,6 +797,17 @@ int fonsAddFallbackFont(FONScontext* stash, int base, int fallback) | |||
| return 0; | |||
| } | |||
|
|
|||
| void fonsResetdFallbackFont(FONScontext* stash, int base) | |||
There was a problem hiding this comment.
Remove extra D:
fonsResetdFallbackFont
There was a problem hiding this comment.
Oops! Just fixed the typo. :)
This commit adds `nvgResetFallbackFontsId()` and `nvgResetFallbackFonts()` functions for resetting fallback fonts.
|
Thanks again for the improvement! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
nvgResetFallbackFontsId()andnvgResetFallbackFonts()functions for resetting fallback fonts. This would be very useful for improved CJK font support.For example. If we always use an English-only font as the base font. We need to make sure the first fallback font is a Japanese font for Japanese articles or a Chinese font for Chinese articles. Right now there is no way to reset fallback fonts and thus the first assigned CJK font will be used across different languages.