fn loop_restoration_filter: Take safe lpf arg for Rust fallbacks
#1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkysen
approved these changes
Jun 14, 2024
| @@ -170,10 +174,22 @@ impl loop_restoration_filter::Fn { | |||
| let dst_ptr = dst.as_mut_ptr::<BD>().cast(); | |||
| let dst_stride = dst.stride(); | |||
| let left = left[..h as usize].as_ptr().cast(); | |||
| let lpf = lpf.cast(); | |||
| // NOTE: The calculated pointer may point to before the beginning of | |||
There was a problem hiding this comment.
Suggested change
| // NOTE: The calculated pointer may point to before the beginning of | |
| // SAFETY: The calculated pointer may point to before the beginning of |
There was a problem hiding this comment.
This isn't a safety comment though. None of the operations it's documenting are unsafe, it's just explaining why we need to use wrapping_offset instead of offset.
There was a problem hiding this comment.
Yeah, but it's very safety adjacent, and explains why we aren't doing something unsafe. I think it's better to use SAFETY for searchability, too.
kkysen
changed the title
loop_restoration_filter: Take safe lpf arg for Rust fallbacksfn loop_restoration_filter: Take safe lpf arg for Rust fallbacks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pass the full
DisjointMutbuffer and anisizeoffset into theloop_restoration_filterfunction, then reconstruct the offset in the Rust fallback functions. This makes the Rust fallbacks fully safe.looprestoration.rs: Unsafe cleanup #852