Skip to content

Remove highlightElevation from RawZefyrButton #103

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kolja-esders
Copy link

Issue

Currently, there is a pretty intense elevation of active toolbar buttons during a long-press. The elevation is also visible for a short period of time when the user toggles an active button to become inactive.

This behavior does not look intended and does not seem coherent with the perception of a simple on/off toggle button (suddenly there is a third dimension out of nowhere).

Fix

The PR explicitly sets the highlightElevation of the underlying RawMaterialButton to 0.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files          12       12           
  Lines        1090     1090           
=======================================
  Hits         1004     1004           
  Misses         86       86

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86c4dd0...5289623. Read the comment docs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant