Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable golangci-lint checks #53

Merged
merged 2 commits into from
Nov 16, 2021
Merged

Enable golangci-lint checks #53

merged 2 commits into from
Nov 16, 2021

Conversation

rustycl0ck
Copy link
Contributor

What this PR does / Why we need it

  • Add updated config for golangci-lint
  • Fix current lint errors
  • Add make targets for downloading and running lint checks
  • Add Actions workflow for running lint checks

Which issue(s) this PR fixes

Fixes #46

@rustycl0ck rustycl0ck requested a review from a team as a code owner November 12, 2021 14:57
tkuchiki
tkuchiki previously approved these changes Nov 15, 2021
Copy link
Contributor

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

* Add config for golangci-lint
* Fix current lint errors

Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
@tkuchiki tkuchiki merged commit 57bf7ea into mercari:master Nov 16, 2021
@rustycl0ck rustycl0ck deleted the ci-lint branch January 28, 2022 04:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable linting at CI for PRs
2 participants