Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch all internal compute capacity to processing units only #66

Merged
merged 2 commits into from
Feb 2, 2022

Conversation

rustycl0ck
Copy link
Contributor

@rustycl0ck rustycl0ck commented Jan 31, 2022

Contents of this PR:

  • convert all internal functions to use only processing-units for computations
  • remove some unnecessary functions to make the codebase smaller, readable and cleaner
  • update/re-generate CRD (automatic, through make manifests)

Signed-off-by: rustyclock <rustyclock@protonmail.com>
@github-actions github-actions bot added size/L and removed size/XL labels Feb 2, 2022
@rustycl0ck rustycl0ck marked this pull request as ready for review February 2, 2022 01:47
@rustycl0ck rustycl0ck requested a review from a team as a code owner February 2, 2022 01:47

desiredProcessingUnits := maxInt(nextValidProcessingUnits(totalCPUProduct1000/targetCPU), currentProcessingUnits-scaledownStepSize*1000)
desiredPU := nextPU
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like to just use the nextPU without the desiredPU.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks! I changed this now.

Signed-off-by: rustyclock <rustyclock@protonmail.com>
Copy link
Contributor

@tkuchiki tkuchiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rustycl0ck rustycl0ck merged commit 1aacf8f into mercari:master Feb 2, 2022
@rustycl0ck rustycl0ck deleted the controller-only-pu branch February 2, 2022 06:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants