Add SpannerAutoscaleSchedule API
#71
Conversation
| kind: CustomResourceDefinition | ||
| metadata: | ||
| annotations: | ||
| cert-manager.io/inject-ca-from: $(CERTIFICATE_NAMESPACE)/$(CERTIFICATE_NAME) |
There was a problem hiding this comment.
It looks like you need to add vars to config/crd/kustomization.yaml like config/default/kustomization.yaml.
There was a problem hiding this comment.
Yes, make deploy (installs the CRD + all other resources) works, but make install does not work because of the missing variables currently. I think this is a scaffolding issue in the Kubebuilder.
As a work-around, I have been using make undeploy deploy (re-installs the CRD as well as all the other resources) or just re-create the Kind cluster sometimes.
To fix this, I will try to find if it is a scaffolding issue or just a documentation issue in Kubebuilder.
For our case, the webhook manifests for SpannerAutoscaleSchedule have not been generated yet. When I enable the webhooks for SpannerAutoscaleSchedule, then I will add these variables too in our configs.
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
Signed-off-by: rustyclock <rustyclock@protonmail.com>
|
Rebased with master to keep the commit history clean. Please have a look again whenever you have time 🙇 |
| log.Info("registering schedule with spanner-autoscaler", "schedule", sas.Name, "autoscaler", sa.Name) | ||
| log.V(1).Info("registering schedule with spanner-autoscaler", "schedule", sas, "autoscaler", sa) |
There was a problem hiding this comment.
One of these logs seems to be good enough.
There was a problem hiding this comment.
I kept two because Debug level logs the full objects, which can be useful for finding issues during local development etc. And at the Info level in production, just the names of the objects should be sufficient to confirm that the newly created schedule was successfully registered with the corresponding autoscaler. No extra clutter there.
I have now removed the Debug level log.
There was a problem hiding this comment.
I see, thank you for your comment!
Signed-off-by: rustyclock <rustyclock@protonmail.com>
The main purpose of this PR is to introduce all the boilerplate code, so that reviewing smaller functionality improvements and feature implementations in future PRs will be easier.
Contents of this PR:
SpannerAutoscaleScheduleAPI boilerplate codeSpannerAutoscaleScheduleAPI schema/structureWithLogcan not be used for initializingSpannerAutoscaleScheduleReconcilerbecause it conflicts with the already presentWithLogfunctional option forSpannerAutoscalerReconciler.WithLog(or any other options) can now be easily reused for multiple typesSpannerAutoscaleScheduleto theSpannerAutoscaler.Status.Scheduleslist (just as a way of sanity check)