Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add unit tests for v1alpha1 ConvertFrom #74

Merged
merged 2 commits into from
Feb 9, 2022

Conversation

shuheiktgw
Copy link
Contributor

What this PR does / Why we need it

Added unit tests for v1alpha1 ConvertFrom. Thank you for your review!

Which issue(s) this PR fixes

None

@shuheiktgw shuheiktgw requested a review from a team as a code owner February 8, 2022 23:45
@github-actions github-actions bot added the size/L label Feb 8, 2022
Copy link
Contributor

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@rustycl0ck rustycl0ck merged commit 932c806 into mercari:master Feb 9, 2022
@shuheiktgw shuheiktgw deleted the add_unit_tests_convert_from branch February 12, 2022 01:46
rustycl0ck pushed a commit to rustycl0ck/spanner-autoscaler that referenced this pull request Apr 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants