Switch from command line flags to config file based options #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shuheiktgw
force-pushed
the
config_file_option
branch
from
47f1b1d to
37a3d16
Compare
shuheiktgw
changed the title
shuheiktgw
commented
Feb 26, 2022
| @@ -18,9 +18,4 @@ spec: | |||
| - "--v=10" | |||
| ports: | |||
| - containerPort: 8443 | |||
| name: https | |||
| - name: manager | |||
There was a problem hiding this comment.
This conflicts with manager_config_patch.yaml so I removed it
tkuchiki
reviewed
Feb 28, 2022
Comment on lines
-24
to
-26
| - "--health-probe-bind-address=:8081" | ||
| - "--metrics-bind-address=127.0.0.1:8080" | ||
| - "--leader-elect" |
There was a problem hiding this comment.
$ kustomize build config/default
...
---
apiVersion: v1
data:
controller_manager_config.yaml: |
apiVersion: controller-runtime.sigs.k8s.io/v1alpha1
kind: ControllerManagerConfig
health:
healthProbeBindAddress: :8081
metrics:
bindAddress: 127.0.0.1:8080
webhook:
port: 9443
leaderElection:
leaderElect: true
resourceName: 54b82eb3.mercari.com
kind: ConfigMap
metadata:
name: spanner-autoscaler-manager-config
namespace: spanner-autoscaler
|
After reviewing @rustycl0ck, we'll merge this PR. |
rustycl0ck
pushed a commit
to rustycl0ck/spanner-autoscaler
that referenced
this pull request
Apr 20, 2022
* Switch from command line flags to config file based options * Update config/default
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / Why we need it
Switched from command line flags to config file-based options.
https://book.kubebuilder.io/component-config-tutorial/tutorial.html
Which issue(s) this PR fixes
None
Steps to test the update