Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update to @fastify/websocket v10 #1089

Merged
merged 5 commits into from
Mar 19, 2024
Merged

Conversation

mcollina
Copy link
Collaborator

No description provided.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the CI is failing with this error? If needed, I may have some to time this evening to help debug this and try to replicate

Error: Package subpath './dist/error' is not defined by "exports" in /home/runner/work/mercurius/mercurius/node_modules/graphql-jit/package.json
    at exportsNotFound (node:internal/modules/esm/resolve:303:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:650:9)
    at resolveExports (node:internal/modules/cjs/loader:591:36)
    at Function.Module._findPath (node:internal/modules/cjs/loader:668:31)
    at Function.Module._resolveFilename (node:internal/modules/cjs/loader:1130:27)
    at Function.Module._load (node:internal/modules/cjs/loader:985:27)
    at Module.require (node:internal/modules/cjs/loader:1235:19)
    at require (node:internal/modules/helpers:176:18)
    at Object.<anonymous> (/home/runner/work/mercurius/mercurius/test/errors.js:11:26)
    at Module._compile (node:internal/modules/cjs/loader:1376:14)

index.d.ts Outdated Show resolved Hide resolved
mcollina and others added 2 commits March 18, 2024 19:07
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Co-authored-by: Jonny Green <hello@jonnydgreen.com>
Copy link
Contributor

@jonnydgreen jonnydgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a change perspective - like with the other PR, it looks like the CI failure is intermittent, I've given the actions a re-run!

Signed-off-by: Matteo Collina <hello@matteocollina.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants