Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add the ability to auto-merge pull requests #418

Merged
merged 2 commits into from
Oct 16, 2020

Conversation

sambhav
Copy link
Contributor

@sambhav sambhav commented Oct 11, 2020

Fixes #395

Better version of #394

We need to add support for both status.* events and check_suite.* events since the former is used by CI like Jenkins/Circle CI and the latter is used by apps like mergeable and Github Actions.

@sambhav
Copy link
Contributor Author

sambhav commented Oct 11, 2020

@jusx @shine2lay review please. I have been using this patch for a while and it works perfectly.

@codecov-io
Copy link

codecov-io commented Oct 11, 2020

Codecov Report

Merging #418 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
+ Coverage   93.84%   93.87%   +0.03%     
==========================================
  Files          74       74              
  Lines        1673     1682       +9     
  Branches      327      329       +2     
==========================================
+ Hits         1570     1579       +9     
  Misses         90       90              
  Partials       13       13              
Impacted Files Coverage Δ
lib/actions/merge.js 84.61% <100.00%> (+4.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37dea01...3f020aa. Read the comment docs.

@sambhav sambhav force-pushed the auto-merge branch 2 times, most recently from f152bb0 to 710b2a0 Compare October 11, 2020 01:32
Copy link
Member

@jusx jusx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Interesting approach with the empty validator. Our original thought was to use a scheduler but I like this better. Nicely done.

I'll approve this as soon as I understand the reasoning behind the node version bump on circleci.

@jusx jusx merged commit 797fd67 into mergeability:master Oct 16, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: add validator for other Github checks in a PR
3 participants