feat: Add more supported events to baseRef validator #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 92.80% 92.83% +0.03%
==========================================
Files 106 106
Lines 2404 2416 +12
Branches 431 433 +2
==========================================
+ Hits 2231 2243 +12
Misses 154 154
Partials 19 19
Continue to review full report at Codecov.
|
abid-mujtaba
force-pushed
the
feat/baseref-events
branch
from
e641066 to
b3eaec3
Compare
abid-mujtaba
changed the title
abid-mujtaba
force-pushed
the
feat/baseref-events
branch
4 times, most recently
from
e1bd7fe to
65942cc
Compare
shine2lay
approved these changes
Dec 1, 2021
|
Thanks @shine2lay. How do I get the |
|
@abid-mujtaba just merged #594, can you please resolve conflict, maybe that may help with the |
- The auto-merge workflow (using the `merge` action) listens to `check_suite.*` events in addition to the more standard `pull-request.*` and `pull_request_review.*`. This workflow relies on branch protections to stop the merge while the check_suite is running. Since branch protections are usually setup **only** only on the default branch it means PRs that are targetting non-default branches are auto-merged by the workflow sometime before the check suite has even completed (if `check_suite.*` is used). - Add `check_suite.*` event support to the baseRef validator so that auto-merge can be limited to the default branch. - If more than one pull request is associated with a check_suite the validator will validate ALL of them and only pass if ALL of them pass - If NO pull requests are associated with a check_suite the validator considers this to be a failure since there is no baseRef to validate - Add unit tests for check_suite events.
abid-mujtaba
force-pushed
the
feat/baseref-events
branch
from
65942cc to
5a8732f
Compare
|
@shine2lay, rebased on master. No luck. |
|
@shine2lay, seems to have gotten unstuck 😄. Ready to merge. |
|
🎉 This PR is included in version 2.9.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mergeaction) listens tocheck_suite.*events in addition to the more standardpull-request.*andpull_request_review.*.This workflow relies on branch protections to stop the merge while
the check_suite is running.
Since branch protections are usually setup only only on the
default branch it means PRs that are targetting non-default
branches are auto-merged by the workflow sometime before the check
suite has even completed (if
check_suite.*is used).check_suite.*event support to the baseRef validator so thatauto-merge can be limited to the default branch.
check_suiteevents.mockContextfixture when using thebaseRefoption.The passed in
baseRefvalue was not being set in the context payload.