feat: add support for status events to baseRef validator #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abid-mujtaba
changed the title
abid-mujtaba
force-pushed
the
feat/baseref-status-events
branch
from
f2903b4 to
36b9106
Compare
Codecov Report
@@ Coverage Diff @@
## master #602 +/- ##
==========================================
+ Coverage 92.83% 92.87% +0.03%
==========================================
Files 106 106
Lines 2416 2427 +11
Branches 433 435 +2
==========================================
+ Hits 2243 2254 +11
Misses 154 154
Partials 19 19
Continue to review full report at Codecov.
|
- For status events the commit sha in the payload is used to make an octokit request to fetch the pull requests to which the commit belongs. The pull requests are filtered to just the open ones. The validator than check the base refs of these open pull requests. - Add unit tests to cover new functionality
abid-mujtaba
force-pushed
the
feat/baseref-status-events
branch
from
36b9106 to
45a15e6
Compare
shine2lay
approved these changes
Dec 22, 2021
|
🎉 This PR is included in version 2.9.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
octokit request to fetch the pull requests to which the commit
belongs.
The pull requests are filtered to just the open ones.
The validator than check the base refs of these open pull requests.