Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: trigger validators on issue_comment #766

Merged

Conversation

andekande
Copy link
Contributor

when a PR comment is created or edited the relevant validators will now recheck the conditions
this is to enable support for, eg:

  - when: issue_comment.created, issue_comment.edited
    name: 'Merge Quality Check'
    validate:
      # validate missing Jira ticket as failure
      - do: title
        must_include:
          regex: '^\[?([A-Za-z]+-\d+)\]?:? '
          message: 'A Jira Ticket ID is not present in the PR title.'
      # validate presence of work-in-progress label as failure
      - do: label
        must_exclude:
          regex: 'work in progress|wip|do not merge'
          message: 'A label indicates work in progress. Do not release yet.'
    pass:
      - do: checks
        status: 'success'
        payload:
          title: 'Qualified For Merge'
    fail:
      - do: checks
        status: 'failure'
        payload:
          title: 'Not Qualified For Merge'

@andekande andekande force-pushed the enable-issue-comment-in-validators branch from dc0b501 to ad595dd Compare July 10, 2024 20:05
@andekande andekande changed the title trigger validators on issue_comment feat: trigger validators on issue_comment Jul 10, 2024
@shine2lay shine2lay merged commit 6f55264 into mergeability:master Jul 29, 2024
1 check passed
Copy link

@invisiblepancake invisiblepancake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trigger val

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants