Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Specify class directly next to node #835

Closed
notramo opened this issue May 12, 2019 · 2 comments
Closed

Specify class directly next to node #835

notramo opened this issue May 12, 2019 · 2 comments
Assignees
Labels
Graph: Flow Type: Enhancement New feature or request

Comments

@notramo
Copy link

notramo commented May 12, 2019

Class definition is too far from node:

A --> B[node text]

classDef myClass fill:#0f0,stroke:#333,stroke-width:3px;
classDef anotherClass fill:#ff0,stroke:#333,stroke-width:3px;

class B anotherClass
class A myClass
Loading

I think it would be easier to understand:

A.myClass --> B[node text].anotherClass

classDef myClass fill:#0f0,stroke:#333,stroke-width:3px;
classDef anotherClass fill:#ff0,stroke:#333,stroke-width:3px;
Loading
@ashishjain0512 ashishjain0512 self-assigned this Jul 9, 2019
knsv added a commit that referenced this issue Jul 25, 2019
…e-flow

#835 Feature/allow class directly at node flow
@knsv
Copy link
Collaborator

knsv commented Aug 26, 2019

The syntax with a single dot is intuitive but unfortunately breaks backwards compatibility in flowcharts as for instance this graph would break:

graph TB
   176.123.34.56 --> 172.123.35.78
Loading

Instead I propose we adapt another delimiter, instead of '.' we can use ':::'

@knsv
Copy link
Collaborator

knsv commented Sep 1, 2019

Released in 8.2.6

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Graph: Flow Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants