-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(docs): Correct repeated text in flowchart.md #4810
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #4810 +/- ##
===========================================
+ Coverage 73.12% 77.60% +4.47%
===========================================
Files 146 146
Lines 14487 14487
Branches 612 612
===========================================
+ Hits 10593 11242 +649
+ Misses 3756 3124 -632
+ Partials 138 121 -17
Flags with carried forward coverage won't be shown. Click here to find out more. |
@andriy-koz, Thank you for the contribution! |
sidharthv96
added a commit
to sidharthv96/mermaid
that referenced
this pull request
Sep 5, 2023
* develop: (31 commits) chore: Update docs New Mermaid Live Editor for Confluence Cloud (mermaid-js#4814) Update link to Discourse theme component (mermaid-js#4811) Update flowchart.md (mermaid-js#4810) chore: Update docs "CSS" instead of "css" in flowchart.md (mermaid-js#4797) Update CONTRIBUTING.md Update CONTRIBUTING.md fix: typos (mermaid-js#4801) chore: Align with convention add additional test case chore(deps): update all patch dependencies chore(deps): update all minor dependencies added test case add sanitize text Update docs modifications to generic parser improvements to parseGenericTypes Update packages/mermaid/src/diagrams/class/svgDraw.js return comment ...
sidharthv96
added a commit
that referenced
this pull request
Sep 6, 2023
* develop: (56 commits) chore: Fix unit tests chore(deps): update all patch dependencies chore: Update docs Update docs New Mermaid Live Editor for Confluence Cloud (#4814) Update link to Discourse theme component (#4811) Update flowchart.md (#4810) chore: remove unneeded `CommomDB` chore: Update docs "CSS" instead of "css" in flowchart.md (#4797) Update CONTRIBUTING.md Update CONTRIBUTING.md fix: typos (#4801) chore: Align with convention chore: Add JSDoc to apply in sequenceDB refactor: Tidy up direction handling chore: Fix flowchart arrow chore: Add test to verify activate chore: Update tests snapshot fix: #4691 Align arrowheads properly in sequenceDiagram ...
sidharthv96
added a commit
to Zumbala/mermaid
that referenced
this pull request
Sep 6, 2023
* develop: (705 commits) chore: Fix unit tests chore(deps): update all patch dependencies chore: Update docs Update docs New Mermaid Live Editor for Confluence Cloud (mermaid-js#4814) Update link to Discourse theme component (mermaid-js#4811) Update flowchart.md (mermaid-js#4810) chore: remove unneeded `CommomDB` chore: Update docs "CSS" instead of "css" in flowchart.md (mermaid-js#4797) Update CONTRIBUTING.md Update CONTRIBUTING.md fix: typos (mermaid-js#4801) chore: Align with convention fix: Add support for `~test Array~string~` chore: Add JSDoc to apply in sequenceDB refactor: Tidy up direction handling chore: Fix flowchart arrow chore: Add test to verify activate chore: Update tests snapshot ...
sidharthv96
added a commit
to rhysd/mermaid
that referenced
this pull request
Sep 6, 2023
* develop: (595 commits) chore: Fix unit tests chore(deps): update all patch dependencies chore: Update docs Update docs New Mermaid Live Editor for Confluence Cloud (mermaid-js#4814) Update link to Discourse theme component (mermaid-js#4811) Update flowchart.md (mermaid-js#4810) chore: remove unneeded `CommomDB` chore: Update docs "CSS" instead of "css" in flowchart.md (mermaid-js#4797) Update CONTRIBUTING.md Update CONTRIBUTING.md fix: typos (mermaid-js#4801) chore: Align with convention fix: Add support for `~test Array~string~` chore: Add JSDoc to apply in sequenceDB refactor: Tidy up direction handling chore: Fix flowchart arrow chore: Add test to verify activate chore: Update tests snapshot ...
sidharthv96
added a commit
to RohanHandore/mermaid
that referenced
this pull request
Sep 6, 2023
* develop: (864 commits) chore: Update docs chore: Fix unit tests chore(deps): update all patch dependencies chore: Update docs Update docs New Mermaid Live Editor for Confluence Cloud (mermaid-js#4814) Update link to Discourse theme component (mermaid-js#4811) Update flowchart.md (mermaid-js#4810) chore: remove unneeded `CommomDB` chore: Update docs "CSS" instead of "css" in flowchart.md (mermaid-js#4797) Update CONTRIBUTING.md Update CONTRIBUTING.md fix: typos (mermaid-js#4801) chore: Align with convention fix: Add support for `~test Array~string~` chore: Add JSDoc to apply in sequenceDB refactor: Tidy up direction handling chore: Fix flowchart arrow chore: Add test to verify activate ...
sidharthv96
added a commit
that referenced
this pull request
Sep 8, 2023
* develop: (189 commits) Remove unnecessary tests Remove optional chaining chore: Update docs refactor: Use `||` instead of `??` Update flowchart.md (#4798) Update flowchart.md (#4792) core: Adapt changes from 3f7bafb Update cypress/helpers/util.js chore: Update docs chore: Add deprecation notices, improve types chore: Cleanup gitGraph tests chore: Fix unit tests chore(deps): update all patch dependencies chore: Update docs Update docs New Mermaid Live Editor for Confluence Cloud (#4814) Update link to Discourse theme component (#4811) Update flowchart.md (#4810) chore: remove unneeded `CommomDB` chore: Update docs ...
fuxingloh
referenced
this pull request
in fuxingloh/contented
Oct 3, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [mermaid](https://github.com/mermaid-js/mermaid) | [`10.4.0` -> `10.5.0`](https://renovatebot.com/diffs/npm/mermaid/10.4.0/10.5.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/mermaid/10.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/mermaid/10.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/mermaid/10.4.0/10.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/mermaid/10.4.0/10.5.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>mermaid-js/mermaid (mermaid)</summary> ### [`v10.5.0`](https://github.com/mermaid-js/mermaid/releases/tag/v10.5.0): 10.5.0 [Compare Source](https://github.com/mermaid-js/mermaid/compare/v10.4.0...v10.5.0) #### What's Changed ##### Features - feat(er): add entity name alias by [@​tomperr](https://github.com/tomperr) in [https://github.com/mermaid-js/mermaid/pull/4758](https://github.com/mermaid-js/mermaid/pull/4758) ##### Bugfixes - Fix Twitter fontawesome class in flowchart.md by [@​GingerNinjaNicko](https://github.com/GingerNinjaNicko) in [https://github.com/mermaid-js/mermaid/pull/4723](https://github.com/mermaid-js/mermaid/pull/4723) - fix(pie): align slices and legend orders by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4774](https://github.com/mermaid-js/mermaid/pull/4774) - Update class member handling by [@​jgreywolf](https://github.com/jgreywolf) in [https://github.com/mermaid-js/mermaid/pull/4534](https://github.com/mermaid-js/mermaid/pull/4534) - fix(er): allow underscore as leading char by [@​tomperr](https://github.com/tomperr) in [https://github.com/mermaid-js/mermaid/pull/4776](https://github.com/mermaid-js/mermaid/pull/4776) - Align arrows on sequence diagram by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4804](https://github.com/mermaid-js/mermaid/pull/4804) - fix: Allow hollow markers on edges by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4788](https://github.com/mermaid-js/mermaid/pull/4788) - fix: Fix for vulnerability making it possible to add javascript in class names by [@​knsv](https://github.com/knsv) ##### Documentation - Docs/2910 Remove n00b and fix some docs by [@​nirname](https://github.com/nirname) in [https://github.com/mermaid-js/mermaid/pull/4767](https://github.com/mermaid-js/mermaid/pull/4767) - fix: typos by [@​omahs](https://github.com/omahs) in [https://github.com/mermaid-js/mermaid/pull/4801](https://github.com/mermaid-js/mermaid/pull/4801) - "CSS" instead of "css" in flowchart.md by [@​jakeboone02](https://github.com/jakeboone02) in [https://github.com/mermaid-js/mermaid/pull/4797](https://github.com/mermaid-js/mermaid/pull/4797) - fix(docs): Correct repeated text in flowchart.md by [@​andriy-koz](https://github.com/andriy-koz) in [https://github.com/mermaid-js/mermaid/pull/4810](https://github.com/mermaid-js/mermaid/pull/4810) - Update link to Discourse theme component by [@​gschlager](https://github.com/gschlager) in [https://github.com/mermaid-js/mermaid/pull/4811](https://github.com/mermaid-js/mermaid/pull/4811) - New Mermaid Live Editor for Confluence Cloud by [@​zhifeiyue](https://github.com/zhifeiyue) in [https://github.com/mermaid-js/mermaid/pull/4814](https://github.com/mermaid-js/mermaid/pull/4814) - Update classDiagram.md by [@​jgreywolf](https://github.com/jgreywolf) in [https://github.com/mermaid-js/mermaid/pull/4781](https://github.com/mermaid-js/mermaid/pull/4781) - Support member definition to initialize class by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4786](https://github.com/mermaid-js/mermaid/pull/4786) - fix: Add support for `~test Array~string~` back in Class by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4805](https://github.com/mermaid-js/mermaid/pull/4805) - Added support for millisecond and second to gantt tickInterval by [@​vertxxyz](https://github.com/vertxxyz) in [https://github.com/mermaid-js/mermaid/pull/4778](https://github.com/mermaid-js/mermaid/pull/4778) - Add directive support to all diagrams by preprocessing by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4759](https://github.com/mermaid-js/mermaid/pull/4759) - Update README.md by [@​jgreywolf](https://github.com/jgreywolf) in [https://github.com/mermaid-js/mermaid/pull/4780](https://github.com/mermaid-js/mermaid/pull/4780) ##### Chores - chore(deps): update all minor dependencies (minor) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4783](https://github.com/mermaid-js/mermaid/pull/4783) - chore(deps): update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4782](https://github.com/mermaid-js/mermaid/pull/4782) - chore(deps): update all patch dependencies (patch) by [@​renovate](https://github.com/renovate) in [https://github.com/mermaid-js/mermaid/pull/4809](https://github.com/mermaid-js/mermaid/pull/4809) - chore: move `commonDb` into `diagrams/common/commonDb` by [@​Yokozuna59](https://github.com/Yokozuna59) in [https://github.com/mermaid-js/mermaid/pull/4802](https://github.com/mermaid-js/mermaid/pull/4802) - Use utf8 encoding in Jupyter example by [@​jonashaag](https://github.com/jonashaag) in [https://github.com/mermaid-js/mermaid/pull/4701](https://github.com/mermaid-js/mermaid/pull/4701) - Update flowchart.md by [@​Ogglas](https://github.com/Ogglas) in [https://github.com/mermaid-js/mermaid/pull/4792](https://github.com/mermaid-js/mermaid/pull/4792) - Update flowchart.md by [@​dsblank](https://github.com/dsblank) in [https://github.com/mermaid-js/mermaid/pull/4798](https://github.com/mermaid-js/mermaid/pull/4798) - Refactor `cypress/helpers/util.ts` by [@​RohanHandore](https://github.com/RohanHandore) in [https://github.com/mermaid-js/mermaid/pull/4340](https://github.com/mermaid-js/mermaid/pull/4340) - refactor: Fix typings in utils.ts by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4826](https://github.com/mermaid-js/mermaid/pull/4826) - Support ClassDefs in external diagrams by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4819](https://github.com/mermaid-js/mermaid/pull/4819) - Fix: flowchartElk Arrow overlap by [@​sidharthv96](https://github.com/sidharthv96) in [https://github.com/mermaid-js/mermaid/pull/4830](https://github.com/mermaid-js/mermaid/pull/4830) - Give markers unique id's per graph by [@​chadfawcett](https://github.com/chadfawcett) in [https://github.com/mermaid-js/mermaid/pull/4825](https://github.com/mermaid-js/mermaid/pull/4825) #### New Contributors - [@​GingerNinjaNicko](https://github.com/GingerNinjaNicko) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4723](https://github.com/mermaid-js/mermaid/pull/4723) - [@​omahs](https://github.com/omahs) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4801](https://github.com/mermaid-js/mermaid/pull/4801) - [@​jakeboone02](https://github.com/jakeboone02) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4797](https://github.com/mermaid-js/mermaid/pull/4797) - [@​andriy-koz](https://github.com/andriy-koz) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4810](https://github.com/mermaid-js/mermaid/pull/4810) - [@​gschlager](https://github.com/gschlager) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4811](https://github.com/mermaid-js/mermaid/pull/4811) - [@​zhifeiyue](https://github.com/zhifeiyue) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4814](https://github.com/mermaid-js/mermaid/pull/4814) - [@​vertxxyz](https://github.com/vertxxyz) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4778](https://github.com/mermaid-js/mermaid/pull/4778) - [@​jonashaag](https://github.com/jonashaag) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4701](https://github.com/mermaid-js/mermaid/pull/4701) - [@​Ogglas](https://github.com/Ogglas) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4792](https://github.com/mermaid-js/mermaid/pull/4792) - [@​dsblank](https://github.com/dsblank) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4798](https://github.com/mermaid-js/mermaid/pull/4798) - [@​RohanHandore](https://github.com/RohanHandore) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4340](https://github.com/mermaid-js/mermaid/pull/4340) - [@​chadfawcett](https://github.com/chadfawcett) made their first contribution in [https://github.com/mermaid-js/mermaid/pull/4825](https://github.com/mermaid-js/mermaid/pull/4825) **Full Changelog**: mermaid-js/mermaid@v10.4.0...v10.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/contented). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjMiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjMiLCJ0YXJnZXRCcmFuY2giOiJtYWluIn0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
This pull request addresses a bug where text gets erroneously repeated in the flowchart representation.