Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hotfix/elk 0.1.7 #6090

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Hotfix/elk 0.1.7 #6090

merged 2 commits into from
Nov 27, 2024

Conversation

ashishjain0512
Copy link
Collaborator

📑 Summary

This pull request includes changes to improve t#6088 ndling of diamond shape intersections in flowcharts using the @mermaid-js/layout-elk package. The main updates involve fixing offset calculations and adding new test cases to ensure proper functionality.

Improvements to diamond shape handling:

Testing enhancements:

HTML updates:

Resolves #6088

📏 Design Decisions

Describe the way your implementation works or what design decisions you made if applicable.

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added necessary unit/e2e tests.
  • 📓 have added documentation. Make sure MERMAID_RELEASE_VERSION is used for all new features.
  • 🦋 If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 654097c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@mermaid-js/layout-elk Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the Type: Bug / Error Something isn't working or is incorrect label Nov 27, 2024
Copy link

netlify bot commented Nov 27, 2024

Deploy Preview for mermaid-js ready!

Name Link
🔨 Latest commit 654097c
🔍 Latest deploy log https://app.netlify.com/sites/mermaid-js/deploys/674743ccb61a4d00080f022c
😎 Deploy Preview https://deploy-preview-6090--mermaid-js.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knsv knsv merged commit b29081d into master Nov 27, 2024
15 of 16 checks passed
@knsv knsv deleted the hotfix/elk-0.1.7 branch November 27, 2024 16:08
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 4.49%. Comparing base (f471333) to head (654097c).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
packages/mermaid-layout-elk/src/render.ts 0.00% 12 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6090   +/-   ##
======================================
  Coverage    4.49%   4.49%           
======================================
  Files         383     382    -1     
  Lines       53925   53904   -21     
  Branches      596     621   +25     
======================================
  Hits         2425    2425           
+ Misses      51500   51479   -21     
Flag Coverage Δ
unit 4.49% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/mermaid-layout-elk/src/render.ts 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@github-actions github-actions bot mentioned this pull request Nov 27, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants